[cfe-commits] [Patch] Typo correction: don't crash on overloaded functions, pr10283
hans at chromium.org
Tue Jul 12 10:49:51 CDT 2011
On Mon, Jul 11, 2011 at 9:39 PM, Kaelyn Uhrain <rikka at google.com> wrote:
> Looks like the indenting on the FIXME you added needs to be fixed so that
> the start of both lines of the comment are equal to each other and to the
> surrounding code, but otherwise the code changes look fine. One big issue
> regarding the unit test though: the test does not test clang's "-fixit"
> code rewrite functionality so should not be under test/FixIt/; test/SemaCXX/
> is the appropriate place for this C++ unit test. Naming the file something a
> bit more descriptive than just "typo-crash.cpp", such as
> "function-overload-typo-crash.cpp", would also be nice.
Landed in r134976, thanks!
More information about the cfe-commits