[cfe-commits] r140574 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td test/SemaCXX/warn-literal-conversion.cpp test/SemaCXX/warn-string-conversion.cpp
rjmccall at apple.com
Mon Sep 26 18:39:04 CDT 2011
On Sep 26, 2011, at 4:30 PM, Richard Trieu wrote:
> On Mon, Sep 26, 2011 at 4:24 PM, John McCall <rjmccall at apple.com> wrote:
>> On Sep 26, 2011, at 3:38 PM, Richard Trieu wrote:
>>> Author: rtrieu
>>> Date: Mon Sep 26 17:38:21 2011
>>> New Revision: 140574
>>> URL: http://llvm.org/viewvc/llvm-project?rev=140574&view=rev
>>> Move string literal to bool conversion into its own warning flag -Wstring-conversion.
>> Why? I'd really rather not minutely slice up warnings without a good justification.
> The string literal to boolean conversion is a new warning. There was
> some discussion of where to put it, from literal-conversion or
> bool-conversion. I was moving it to its own flag so we can have the
> warning while we figure out which of these places would be best for
Okay, as long as it doesn't stay there. And for next time, it's fine to just let it sit in one or the other until the discussion is done, I think.
More information about the cfe-commits