[cfe-commits] [Patch] -Wformat-non-standard: warn about positional arguments (pr12017)
richard at metafoo.co.uk
Wed Mar 7 14:55:41 CST 2012
On Wed, Mar 7, 2012 at 11:35 AM, Ted Kremenek <kremenek at apple.com> wrote:
> I think I only have a minor nit:
> + "the '%0' %1 is not supported by ISO C">, InGroup<FormatNonStandard>,
> It seems weird to start a diagnostic with "the". Why include it?
> Dropping it changes:
> the 'q' length modifier is not supported by ISO C
> 'q' length modifier is not supported by ISO C
> The second seems just fine for a warning.
I have another issue with this diagnostic: it's substituting %1 for either
"conversion specifier" or "length modifier". That's a violation of the
rules for diagnostics since it's not translatable. While you're here, can
you change this to a %select?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits