[cfe-commits] [PATCH] make __builtin_annotation generic
jlerouge at apple.com
Sat Apr 28 12:42:53 CDT 2012
On Tue, Apr 24, 2012 at 02:51:13PM -0400, Xi Wang wrote:
> On Apr 24, 2012, at 2:34 PM, Julien Lerouge wrote:
> > Looks good to me. Thanks.
> > The only thing I'd be worried about is that this could break current
> > users of those annotations who expect the casts (although it would be an
> > easy fix). That's the reason why I kept the casts when I backported this
> > thing from llvm-gcc.
> Hi Julien,
> Thanks for reviewing.
> I agree with the compatibility concern. Hope people will like the
> patch since now it's way easier to extract the annotation (as well
> as a correct semantics compared to the odd truncation-extension).
> > I'll apply your patch (unless you have commit access?).
> No, I don't. Thanks a lot for the help.
PGP Key Id: 0xB1964A62
PGP Fingerprint: 392D 4BAD DB8B CE7F 4E5F FA3C 62DB 4AA7 B196 4A62
PGP Public Key from: keyserver.pgp.com
More information about the cfe-commits