[cfe-dev] Implementing -Wunused-variables
dgregor at apple.com
Thu Oct 8 16:38:52 CDT 2009
On Oct 6, 2009, at 9:12 AM, Oscar Bonilla wrote:
> On Oct 5, 2009, at 11:37 PM, Oscar Bonilla wrote:
>> On Oct 5, 2009, at 9:46 PM, Oscar Bonilla wrote:
>>> Is this any better?
>> Still not quite right:
> Ok, this one seems to do the trick:
> I ran "make test" and only got one failure:
> FAIL: Clang::Index/c-index-api-test.m (646 of 1636)
> which seems unrelated. I also compiled Adium with it and didn't get
> any obvious false positives or false negatives.
Wonderful, thank you! I've committed this patch here:
along with your suggested micro-optimization. We love optimizations of
all kinds, and moving the isUsed() check first will save a lot of
isa<> checks. Good catch!
More information about the cfe-dev