[cfe-dev] Patch to allow comment translators implementation

Douglas Gregor dgregor at apple.com
Fri Jan 15 22:21:27 CST 2010



Sent from my iPhone

On Jan 15, 2010, at 7:17 AM, Abramo Bagnara <abramobagnara at tin.it>  
wrote:

> Il 12/01/2010 22:40, Chris Lattner ha scritto:
>>> The only proposal I see that would not change a lot of things is to
>>> remove Token argument from CommentHandler and to specify that they
>>> always shall use EnterTokenStream also when they need to insert  
>>> only one
>>> token.
>>> Then at end of Preprocessor::HandleComment if any of the comment
>>> handlers has informed the caller to have inserted some tokens the  
>>> first
>>> one available is fetched and returned by  
>>> Preprocessor::HandleComment.
>>
>> Yes, I think this is a good plan.
>
> You find attached a revised patch (based on r93512) that work as  
> designed.
>
> The patch passes all clang tests.

Looks fine to me. Chris?

   - Doug


More information about the cfe-dev mailing list