[cfe-dev] Patch to allow comment translators implementation
clattner at apple.com
Mon Jan 18 16:36:26 CST 2010
>> Il 12/01/2010 22:40, Chris Lattner ha scritto:
>>>> The only proposal I see that would not change a lot of things is to
>>>> remove Token argument from CommentHandler and to specify that they
>>>> always shall use EnterTokenStream also when they need to insert
>>>> only one
>>>> Then at end of Preprocessor::HandleComment if any of the comment
>>>> handlers has informed the caller to have inserted some tokens the
>>>> one available is fetched and returned by
>>> Yes, I think this is a good plan.
>> You find attached a revised patch (based on r93512) that work as
>> The patch passes all clang tests.
> Looks fine to me. Chris?
Looks good to me, committed in r93795. I didn't commit the lib/Lex/
PPDirectives.cpp hunk, because it didn't look necessary. Please
correct me if I'm wrong.
More information about the cfe-dev