[Lldb-commits] [lldb] r148521 - /lldb/trunk/source/Interpreter/CommandObject.cpp

Johnny Chen johnny.chen at apple.com
Thu Jan 19 18:59:20 CST 2012


Author: johnny
Date: Thu Jan 19 18:59:19 2012
New Revision: 148521

URL: http://llvm.org/viewvc/llvm-project?rev=148521&view=rev
Log:
Add comment describing the interaction of WantsRawCommandString()/WantsCompletion() with the completion mechanism.

Modified:
    lldb/trunk/source/Interpreter/CommandObject.cpp

Modified: lldb/trunk/source/Interpreter/CommandObject.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/CommandObject.cpp?rev=148521&r1=148520&r2=148521&view=diff
==============================================================================
--- lldb/trunk/source/Interpreter/CommandObject.cpp (original)
+++ lldb/trunk/source/Interpreter/CommandObject.cpp Thu Jan 19 18:59:19 2012
@@ -344,6 +344,10 @@
     StringList &matches
 )
 {
+    // Default implmentation of WantsCompletion() is !WantsRawCommandString().
+    // Subclasses who want raw command string but desire, for example,
+    // argument completion should override WantsCompletion() to return true,
+    // instead.
     if (WantsRawCommandString() && !WantsCompletion())
     {
         // FIXME: Abstract telling the completion to insert the completion character.




More information about the lldb-commits mailing list