[llvm-commits] [llvm] r76841 - in /llvm/trunk: include/llvm/LLVMContext.h include/llvm/MDNode.h lib/AsmParser/LLParser.cpp lib/Bitcode/Reader/BitcodeReader.cpp lib/Bitcode/Writer/BitcodeWriter.cpp lib/VMCore/AsmWriter.cpp lib/VMCore/LLVMContext.c
daniel at zuster.org
Thu Jul 23 13:16:12 CDT 2009
On Wed, Jul 22, 2009 at 7:01 PM, Devang Patel<dpatel at apple.com> wrote:
> Author: dpatel
> Date: Wed Jul 22 21:00:51 2009
> New Revision: 76841
> URL: http://llvm.org/viewvc/llvm-project?rev=76841&view=rev
> - Rename member function size(). New name is length().
Was this in response to feedback? size() is slightly more consistent, I think?
> - Store string beginning and length. Earlier it used to store string end.
Can you change this to use a StringRef instead? It should simplify the API.
MDNode is also inconsistent in its use of accessors, StrBegin is
accessed directly but length is a method. I think this problem gets
cleaned up with the move to StringRef, however.
More information about the llvm-commits