[llvm-commits] [llvm] r82570 - /llvm/trunk/include/llvm/Support/IRBuilder.h

Devang Patel devang.patel at gmail.com
Wed Sep 23 12:11:13 CDT 2009


On Tue, Sep 22, 2009 at 6:50 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Sep 22, 2009, at 1:56 PM, Devang Patel wrote:
>
>> Author: dpatel
>> Date: Tue Sep 22 15:56:31 2009
>> New Revision: 82570
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=82570&view=rev
>> Log:
>> Add SetLocation() to allow IRBuilder user to set location info for
>> an instruction already created.
>>
>> Modified:
>>    llvm/trunk/include/llvm/Support/IRBuilder.h
>
> Devang,  Builder->SetLocation(I)  sounds like it sets the location of
> the builder, not the instruction.  Can you pick a better name for this?
>
> SetCurrentLocation also has a similar problem.  How about
> SetDebugLocation() ?

OK.
-
Devang




More information about the llvm-commits mailing list