[llvm-commits] [llvm] r85685 - in /llvm/trunk: lib/Target/ARM/ARMISelLowering.cpp test/CodeGen/ARM/long_shift.ll
grosbach at apple.com
Sat Oct 31 16:45:55 CDT 2009
On Oct 31, 2009, at 2:42 PM, Chris Lattner wrote:
> On Oct 31, 2009, at 2:22 PM, Jim Grosbach wrote:
>>> Hi Jim,
>>> Any reason not to include the full code expected for this function
>>> in the test?
>> Hi Chris,
>> Consistency with what was being tested prior to my changes to code
>> gen, basically.
>> More specifically, due to the trunc instruction, some of the 64-bit
>> shift code is being removed (correctly). Previously, the test was
>> checking to make sure the shift was being done via a libcall, so
>> now that it's inline, I'm looking for a representative instruction
>> the indicates it's been done that way instead. If I check for the
>> full instruction sequence, also testing the other aspects of what's
>> happening, which is outside the scope of what I believe this test
>> is intended for.
> Sure, but if the other stuff stops working, we'd still want to know
> about it. It doesn't harm the test (in terms of making it more
> fragile) and gets more value out of the same test, please do it.
No problem; will do. I don't disagree at all. Just answering the
More information about the llvm-commits