[llvm-commits] Proof of concept patch for unifying the .s/ELF emission of .ARM.attributes
espindola at google.com
Fri Oct 15 23:04:40 CDT 2010
> There's about 30 tests that currently depend upon the decimal output.
> And maybe lots more in the test-suite.
> I don't want to do that in the same patch. I'll add a simplified
> --hex, and --dec (default) option switch the default once I clean up
> the tests.
elf-dump is only used in "make check-lit", so changing the tests to
use hex shouldn't be hard. You can change just the script and the
tests in the first commit. Example of a similar change:
126 // Slots for keeping state for above member funcs.
127 MCObjectStreamer *ELFStreamer;
128 MCAssembler *Asm;
You don't need all this. As the initialization show you get the asm
from the streamer for example
Asm = &ELFStreamer->getAssembler();
Why do you have many " char empty = 0;". If this is a standard
constant you should put it in a enum somewhere.
// ('S') (i.e. the -F¡classic¢ programmer¢s model)-A
Corrupted file? Has some strange looking characters.
Rafael Ávila de Espíndola
More information about the llvm-commits