[llvm-commits] [llvm] r122993 - in /llvm/trunk: include/llvm/CodeGen/ISDOpcodes.h lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
bob.wilson at apple.com
Fri Jan 7 16:35:53 CST 2011
On Jan 6, 2011, at 11:52 PM, Duncan Sands wrote:
> Hi Bob,
>> Change EXTRACT_SUBVECTOR to require a constant index.
> how about storing the index as an "int" in the node, rather than using a
> constant node?
I just tried that. It seems to be more trouble than it's worth. There are as many places where it's easier to have a constant node (e.g., the ARM .td file and LegalizeDAG's ExpandExtractFromVectorThroughStack, which handles both EXTRACT_VECTOR_ELT and EXTRACT_SUBVECTOR) as there are places where an "int" is better.
More information about the llvm-commits