[llvm-commits] [PATCH] Improved threading support on Windows
aaron at aaronballman.com
Mon Sep 19 16:53:28 CDT 2011
On Mon, Sep 19, 2011 at 2:51 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> Aaron, threading stuff has been applied in r140011 with a little
> tweak, thank you.
> _beginthreadex() would be preferred with msvcrt, IMHO.
Thank you for the review. I learned something new about Win32 today
(which is no small feat) -- I didn't know that _beginthreadex was the
way to create threads which may interact with the CRT, and that
CreateThread would cause (small) leaks. So thank you for that!
> I apologize to you so much to wait too long, though, I don't think
> simpler patch could be always applied too easily. I needed my time to
> check and investigate patches.
> Please be patient to me. LLVM is still a hobby to me. I am not
> full-time nor dedicated committer.
> (Yeah, today afternoon, I am free from my family)
I am glad the review process is taken seriously because it does find
better ways to do things. So you have no need to apologize to me for
not having the time to attend to your hobby! Open source work
shouldn't be a chore. ;-)
But this may point out a minor problem with the system in that it
takes almost a month for Win32 reviews. Takumi does a wonderful job
as a reviewer (as does Anton), but we may want to explore ways to
ensure a faster turnaround time for Win32 patches. One that doesn't
put undue burden on anyone, obviously.
Just a thought. :-) Thanks again for the review, Takumi!
More information about the llvm-commits