[llvm-commits] [cfe-commits] [PATCH] Potential fix for PR9614
eli.friedman at gmail.com
Tue Oct 11 15:28:01 CDT 2011
On Sun, Oct 9, 2011 at 12:11 PM, Peter Collingbourne <peter at pcc.me.uk> wrote:
> These patches (for Clang and LLVM) together fix PR9614.
> The Clang patch causes it to mark self calls to available_externally
> functions via an asm label as noinline, and the LLVM patch inhibits
> certain optimizations, including tail call elimination, for noinline
> calls to available_externally functions, forcing a call to the external
> version of the function.
> Any thoughts on this approach? Is this OK to commit?
I really don't like overloading the semantics of noinline in this
way... noinline is supposed to prevent inlining, not stop every
optimization that might examine the contents of the function. If you
need to represent something new, use a new call attribute, or
something like that. (Granted, that's still a bit messy, but I can't
think of a particularly better solution... the only other thing I can
think of is abusing aliases somehow to get the desired semantics,
using a special kind of linkage. Possibly more localized, but aliases
can get messy.)
More information about the llvm-commits