[llvm-commits] MachOObjectFile fix functions

Danil Malyshev dmalyshev at accesssoftek.com
Fri Nov 11 16:59:32 CST 2011


Hello Owen

> I see your reasoning here, but it scares me a little bit to have methods with the same name that do different things.
> I think we should either rename them to be obviously different, or pick a consistent meaning for all of them.

I have renamed symbol.getOffset() as getFileOffset().
Please find attached the changed patch.

Regards,
Danil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.cs.uiuc.edu/pipermail/llvm-commits/attachments/20111111/d5ebe17b/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ObjectFile_fix_functions-03.patch
Type: application/octet-stream
Size: 20030 bytes
Desc: ObjectFile_fix_functions-03.patch
Url : http://lists.cs.uiuc.edu/pipermail/llvm-commits/attachments/20111111/d5ebe17b/attachment.obj 


More information about the llvm-commits mailing list