[llvm-commits] [PATCHES] fix JIT optimization level bug
baldrick at free.fr
Sun Nov 27 12:07:43 CST 2011
> The first two patches fix two different bugs introduced with r144788:
> first, the CodeGenOpt enum was being cast into
> addPassesToEmitMachineCode()'s optional 'bool DisableVerify' argument
> after the old optimization argument was removed in the api change
> (would a warning on implicitly casting enum to bool be a good idea?);
> and second, the TargetMachine wasn't being created with the
> optimization level requested. The rest are just code cleanups after
please don't send 8 patches attached to one email, please send 8 emails.
Or, better, two emails each with one patch since logically speaking there
are two different patches: fix up optlevel, move target triples about.
In short, one logical change per email/patch please.
> Okay to commit?
They look OK, except why pass in the target triple as a string only to turn
it into a triple object - why not pass in a triple object from the beginning?
More information about the llvm-commits