[llvm-commits] [llvm] r146735 - in /llvm/trunk: CMakeLists.txt include/llvm/Support/JSONParser.h lib/Support/CMakeLists.txt lib/Support/JSONParser.cpp test/CMakeLists.txt test/Other/json-bench-test.ll unittests/CMakeLists.txt unittests/Support/JS
clattner at apple.com
Fri Dec 16 16:37:28 CST 2011
On Dec 16, 2011, at 12:07 PM, Manuel Klimek wrote:
> On Fri, Dec 16, 2011 at 8:55 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> On Fri, Dec 16, 2011 at 5:09 AM, Manuel Klimek <klimek at google.com> wrote:
>>> Author: klimek
>>> Date: Fri Dec 16 07:09:10 2011
>>> New Revision: 146735
>>> URL: http://llvm.org/viewvc/llvm-project?rev=146735&view=rev
>>> Adds a JSON parser and a benchmark (json-bench) to catch performance regressions.
>> I'm not entirely convinced we need a JSON parser in LLVM to parse
>> output from CMake... Daniel, have you been keeping track of what is
>> happening here?
> This was reviewed by Michael Spencer (discussed on IRC) and he told me
> to go ahead and check it in - he's going to look into evolving this
> into a YAML parser.
I was also skeptical of this :). However, I think it makes sense. Michael and Nick want to have a human-writable data interchange format for the linker regression tests and serializing build stuff seems like a reasonable goal too.
My requirements are 1) that we only have one standardized data interchange format that everything in LLVM uses and 2) it isn't XML :)
More information about the llvm-commits