[llvm-commits] [compiler-rt] r149875 - /compiler-rt/trunk/lib/asan/asan_malloc_win.cc
kcc at google.com
Mon Feb 6 14:55:16 CST 2012
On Mon, Feb 6, 2012 at 11:13 AM, Sebastian Redl <
sebastian.redl at getdesigned.at> wrote:
> On 06.02.2012, at 18:56, Kostya Serebryany wrote:
> > Author: kcc
> > Date: Mon Feb 6 11:56:38 2012
> > New Revision: 149875
> > URL: http://llvm.org/viewvc/llvm-project?rev=149875&view=rev
> > Log:
> > [asan] The first version of Windows malloc interceptors, patch by
> timurrrr at google.com
> > +// FIXME: Simply defining functions with the same signature in *.obj
> > +// files overrides the standard functions in *.lib
> > +// This works well for simple helloworld-like tests but might need to be
> > +// revisited in the future.
> Do you support mixing non-asan modules (DLLs) with asan modules?
If you mean modules instrumented with asan compiler module vs
non-instrumented modules -- yes.
(although we had at least one bug in the past related to this case)
> I can see trouble there, if a module allocates with native malloc and
> another frees with asan malloc, or vice versa.
There is only one malloc in the process. Usually.
If you do end up with two mallocs in the process and they are mixed as you
describe -- you will be in trouble.
(The question is not related to this particular change, right?)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits