[llvm-commits] Patch to use proper calling convention for i386--win32 _ftol2 runtime function
Jakob Stoklund Olesen
stoklund at 2pi.dk
Fri Feb 10 15:27:26 CST 2012
On Feb 9, 2012, at 12:50 PM, Joe Groff <arcata at gmail.com> wrote:
> On Fri, Jan 27, 2012 at 1:48 PM, Joe Groff <arcata at gmail.com> wrote:
>> Here's a patch that adds a WIN_FTOL_* family of pseudo-instructions
>> modelling the unique calling convention used by the Win32 _ftol2
>> runtime function. I'm not totally happy with the tests I wrote; even
>> using -O0, it appears to depend on the behavior of the scheduler
>> somewhat, so any feedback on how to write a more robust test would be
>> appreciated, along with any other comments. Thanks Jakob Stoklund
>> Olesen for walking me through things.
> Here's a revised version of the patch with additional tests to test
> the kill and no-kill cases for the new FTOL pseudo-instruction.
LGTM. Please also add a test for not-Windows. We don't want this to show up on other platforms.
More information about the llvm-commits