[llvm-commits] [ASan] add full strtoll implementation and interceptor (issue 5876052)
joerg at britannica.bec.de
Thu Mar 22 18:59:47 CDT 2012
On Thu, Mar 22, 2012 at 09:15:11AM -0700, Kostya Serebryany wrote:
> I support the intention but I don't like the approach.
> You effectively reimplemented strtoll, which may appear to be even more
> complex function than it looks.
> Now we suddenly need to have an exhaustive test for this part of libc,
> including messy errno business.
It would be nice to at least use an existing and well tested libc
implementation. Especially since I don't see why strtoll should special
cased like this.
More information about the llvm-commits