[LLVMdev] [PATCH] Support for ARM Run-Time ABI (FP and Integer helper functions)
deeppatel1987 at gmail.com
Tue Sep 28 12:21:26 CDT 2010
I wrote that loop. :-)
So now the differences between this patch and the one I had been sitting on are:
* We have opposite condition codes in our FP comparisons.
* This patch has integer division, which seems like a good thing, but
wasn't needed for my A9 target.
Are you sure about the comparisons?
On Tue, Sep 28, 2010 at 9:11 AM, Evzen Muller <evzen.muller at arm.com> wrote:
> Hi Deep,
> Loop for setting all libcall calling conventions to ARM_AAPCS was
> in original version, but I agree that it could have unexpected
> side effects.
> Attached patch sets calling convention only for added libcalls.
>> -----Original Message-----
>> From: Sandeep Patel [mailto:deeppatel1987 at gmail.com]
>> Sent: 27 September 2010 19:50
>> To: Evzen Muller
>> Cc: llvmdev at cs.uiuc.edu
>> Subject: Re: [LLVMdev] [PATCH] Support for ARM Run-Time ABI (FP and
>> Integer helper functions)
>> On Mon, Sep 27, 2010 at 5:02 PM, Evzen Muller <evzen.muller at arm.com>
>> > To make it easier to review & commit I have split and cleaned-up our
>> > original
>> > "Support for ARM Run-Time ABI" patch, this part adds support for calls
>> > can be mapped using setLibcallName.
>> As noted in the earlier thread on this, I'm pretty sure that we need
>> to only apply the AAPCS calling convention to exactly the set of
>> libcalls that you're adding here. Other libcalls outside this set
>> should use the "native" calling convention such as AAPCS-VFP.
More information about the LLVMdev